fix(hook/webhook)!: clean up rename repo code with EventAction and shift defer func #641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #641 +/- ##
==========================================
- Coverage 55.36% 55.21% -0.16%
==========================================
Files 195 195
Lines 15827 15867 +40
==========================================
- Hits 8763 8761 -2
- Misses 6695 6737 +42
Partials 369 369
|
wass3r
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…into fix/hook-updates-no-repo
cognifloyd
approved these changes
May 23, 2022
wass3r
approved these changes
May 27, 2022
Collaborator
wass3r
left a comment
wass3r
left a comment
There was a problem hiding this comment.
should be in v0.14 - we'll have to update the migrations utility
Collaborator
|
added to migration utility PR: go-vela/community@04d422a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes go-vela/community#586
With the defer function being declared before the
nilbuild check, any repository event was resulting in an error since there was norepo_idin the hook object. Also, cleaning up the repository renaming code by adding theevent_actionfield to hook.