Skip to content

Conversation

@jbrockopp
Copy link
Contributor

@jbrockopp jbrockopp added the bug Indicates a bug label May 18, 2022
@jbrockopp jbrockopp requested a review from a team as a code owner May 18, 2022 19:04
@jbrockopp jbrockopp self-assigned this May 18, 2022
@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #642 (50084ec) into master (1c061a4) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #642      +/-   ##
==========================================
+ Coverage   55.34%   55.37%   +0.02%     
==========================================
  Files         195      195              
  Lines       15836    15829       -7     
==========================================
  Hits         8765     8765              
+ Misses       6702     6695       -7     
  Partials      369      369              
Impacted Files Coverage Δ
api/build.go 1.67% <0.00%> (+0.01%) ⬆️

Copy link
Member

@cognifloyd cognifloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will there be a time that we won't need to fall back to the legacy behavior? Eg for a v1.0 release?

@wass3r
Copy link
Collaborator

wass3r commented May 18, 2022

@cognifloyd this particular change is forward and backward compatible, so if we wanted to drop legacy support, this edit wouldn't change.

@wass3r wass3r merged commit 9c89282 into master May 18, 2022
@wass3r wass3r deleted the fix/api/build/restart branch May 18, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Indicates a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

restarting a pre-0.14 build produces an error

4 participants