-
Notifications
You must be signed in to change notification settings - Fork 30
fix(api): always set Strict-Transport-Security header #644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #644 +/- ##
==========================================
- Coverage 55.37% 55.36% -0.01%
==========================================
Files 195 195
Lines 15830 15827 -3
==========================================
- Hits 8766 8763 -3
Misses 6695 6695
Partials 369 369
|
JordanSussman
approved these changes
May 23, 2022
cognifloyd
reviewed
May 23, 2022
wass3r
approved these changes
May 23, 2022
cognifloyd
approved these changes
May 23, 2022
kneal
approved these changes
May 24, 2022
Contributor
kneal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enforces the API to utilize HTTP Strict-Transport-Security (HSTS):
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Strict-Transport-Security
To accomplish this, we set a header to inform browsers that the site should only be accessed using HTTPS:
server/router/middleware/header.go
Line 56 in 8bf333d
This was flagged, as a low finding, by Cargill's security team during a penetration test of the system.
Their argument is by not enforcing secure connections, via HSTS, enables someone to exploit the product.
If an adversary were positioned in the middle of the endpoint and the server, they could use that against the system.