fix: all alerts flagged by CodeQL #645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #645 +/- ##
=======================================
Coverage 55.37% 55.37%
=======================================
Files 195 195
Lines 15829 15830 +1
=======================================
+ Hits 8765 8766 +1
Misses 6695 6695
Partials 369 369
|
cognifloyd
approved these changes
May 23, 2022
wass3r
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses all code scanning alerts flagged by CodeQL:
https://github.com/go-vela/server/security/code-scanning
To accomplish this, some helper functions were added to the
utilpackage that strip newlines and HTML escape strings.Before
https://github.com/go-vela/server/security/code-scanning?query=is%3Aopen+branch%3Amaster
After
https://github.com/go-vela/server/security/code-scanning?query=is%3Aopen+pr%3A645+