Skip to content

fix: lookup of pipelines for older builds #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wass3r merged 15 commits into from
Jun 1, 2022
Merged

fix: lookup of pipelines for older builds #650

wass3r merged 15 commits into from
Jun 1, 2022

Conversation

@jbrockopp
Copy link
Contributor

@jbrockopp jbrockopp commented May 31, 2022 •
edited
Loading

@jbrockopp
Merge branch 'master' of github.com:go-vela/server
57e5162
@jbrockopp
Merge branch 'master' of github.com:go-vela/server
b6b840c
@jbrockopp
Merge branch 'master' of github.com:go-vela/server
858c818
@jbrockopp
Merge branch 'master' of github.com:go-vela/server
ceddb11
@jbrockopp
Merge branch 'master' of github.com:go-vela/server
331b2a2
@jbrockopp
Merge branches 'master' and 'master' of github.com:go-vela/server
c4ec5fb
@jbrockopp
Merge branch 'master' of github.com:go-vela/server
30c1151
@jbrockopp
Merge branch 'master' of github.com:go-vela/server
0ddc31c
@jbrockopp
Merge branch 'master' of github.com:go-vela/server
890f9fa
@jbrockopp
Merge branch 'master' of github.com:go-vela/server
cf4ca0e
@jbrockopp
Merge branch 'master' of github.com:go-vela/server
175e5c5
@jbrockopp
feat(database): add GetLastCommitBuild()
566255d
@jbrockopp
fix(api/pipeline): looking up configs for older builds
b666fbb
@jbrockopp jbrockopp added the bug Indicates a bug label May 31, 2022
@jbrockopp jbrockopp self-assigned this May 31, 2022
@codecov
Copy link

codecov bot commented May 31, 2022 •
edited
Loading

Codecov Report

Merging #650 (01ee2c7) into master (05f8b42) will decrease coverage by 0.02%.
The diff coverage is 46.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #650      +/-   ##
==========================================
- Coverage   55.20%   55.17%   -0.03%     
==========================================
  Files         195      195              
  Lines       15875    15896      +21     
==========================================
+ Hits         8763     8770       +7     
- Misses       6741     6753      +12     
- Partials      371      373       +2
Impacted Files Coverage Δ
router/middleware/pipeline/pipeline.go 77.41% <46.15%> (-22.59%) ⬇️

@jbrockopp jbrockopp marked this pull request as ready for review June 1, 2022 12:05
@jbrockopp jbrockopp requested a review from a team as a code owner June 1, 2022 12:05
cognifloyd
cognifloyd approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@cognifloyd cognifloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wass3r wass3r merged commit a7d8962 into master Jun 1, 2022
@wass3r wass3r deleted the fix/pipeline/lookup branch June 1, 2022 17:16
@colindean colindean mentioned this pull request Aug 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wass3r wass3r wass3r approved these changes

@cognifloyd cognifloyd cognifloyd approved these changes

@plyr4 plyr4 plyr4 approved these changes

Assignees

@jbrockopp jbrockopp

Labels

bug Indicates a bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pre-0.14 generated build can not render a compiled pipeline

5 participants

@jbrockopp @wass3r @cognifloyd @plyr4