fix(webhook): avoid panics #671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wass3r
commented
Jul 14, 2022
Comment on lines
-405
to
-412
| // check if the retry limit has been exceeded | ||
| if i < retryLimit { | ||
| logrus.WithError(retErr).Warning("retrying") | ||
|
|
||
| // continue to the next iteration of the loop | ||
| continue | ||
| } | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
opted to remove this retry logic since ConfigBackoff is already retrying 5x. if that fails it's likely this is just failing, period.
Codecov Report
@@ Coverage Diff @@
## master #671 +/- ##
==========================================
- Coverage 55.07% 54.96% -0.11%
==========================================
Files 195 195
Lines 15926 15956 +30
==========================================
Hits 8771 8771
- Misses 6781 6811 +30
Partials 374 374
|
wass3r
commented
Jul 14, 2022
| b, _ = database.GetBuild(b.GetNumber(), r) | ||
| // TODO: this can be dropped once we return | ||
| // the created build above | ||
| b, err = database.GetBuild(b.GetNumber(), r) |
Collaborator
Author
There was a problem hiding this comment.
if we don't handle any potential errors here, we will get issues downstream from here
wass3r
commented
Jul 14, 2022
| h.SetStatus(constants.StatusFailure) | ||
| h.SetError(retErr.Error()) | ||
|
|
||
| return |
Collaborator
Author
There was a problem hiding this comment.
we probably don't want to return a build if there was an error. this also creates a conflict because this sets a 500 return code that later gets changed to a 200.
cognifloyd
approved these changes
Jul 15, 2022
plyr4
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes go-vela/community#643
most details on this can be found in the issue above. i commented some of the changes.
we also added some TODOs for things to look at in lieu of creating new issues to start some conversation and not lose track of it.
we are adding to top of HEAD since there were only two minor merges that only impact tests.