fix(router/pipeline): change expand, validate, and compile to MustRead #674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #674 +/- ##
=======================================
Coverage 54.96% 54.96%
=======================================
Files 195 195
Lines 15956 15956
=======================================
Hits 8771 8771
Misses 6811 6811
Partials 374 374 |
ecrupper
changed the title
ecrupper
changed the title
wass3r
approved these changes
Jul 18, 2022
wass3r
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since expand pipeline aggregates information that is already available for those with read permissions, it makes sense to have the expand endpoint match that level of accessibility.