fix(scm/webhook): turn off pr:edited events #677
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until we give users the ability to opt-in for the
editedaction for PR events, the added webhook noise is resulting in unexpected behavior.For example, if a user has a step:
That step is ignored due to the fact that
pull_request==pull_request:opened, pull_request:synchronize. Another way to say this: we accommodated legacy pull request ruleset on the yaml side but not the webhook side.As a band-aid, we can turn off the firehose for edited actions until we have a more robust way of handling it.