Skip to content

fix(build/ruleset): handle legacy PR ruleset for restarted build #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wass3r merged 6 commits into from
Jul 21, 2022
Merged

fix(build/ruleset): handle legacy PR ruleset for restarted build #678

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b9a2b12
fix(build/ruleset): handle legacy PR ruleset for restarted build
ecrupper Jul 21, 2022
3c55b7d
Merge branch 'master' into fix/restarted-pr-event
wass3r Jul 21, 2022
a30c93b
clearer comment
ecrupper Jul 21, 2022
44b3e41
Merge branch 'fix/restarted-pr-event' of github.com:go-vela/server in…
ecrupper Jul 21, 2022
8768c5d
add extra clarification
ecrupper Jul 21, 2022
719ad0e
linter overlord
ecrupper Jul 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions api/build.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -990,6 +990,15 @@ func RestartBuild(c *gin.Context) {
b.SetRuntime("")
b.SetDistribution("")

// update the PR event action if action was never set
// for backwards compatibility with pre-0.14 releases.
if b.GetEvent() == constants.EventPull && b.GetEventAction() == "" {
// technically, the action could have been opened or synchronize.
// will not affect behavior of the pipeline since we did not
// support actions for builds where this would be the case.
b.SetEventAction(constants.ActionOpened)
}

// set the parent equal to the restarted build number
b.SetParent(b.GetNumber())
// update the build numbers based off repo counter
Expand Down