-
Notifications
You must be signed in to change notification settings - Fork 30
enhance(metrics)!: query parameter support on metrics endpoint #682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #682 +/- ##
==========================================
- Coverage 55.20% 55.07% -0.13%
==========================================
Files 201 201
Lines 15916 15952 +36
==========================================
Hits 8786 8786
- Misses 6752 6788 +36
Partials 378 378
|
cognifloyd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't use the metrics endpoint so far, but this looks sane from reading.
ecrupper
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
what?
this adds query parameter support to the
/metricsendpoint.why?
without selective querying, the
/metricsendpoint will perform expensive and exhaustive queries to retrieve information from the databasebreaking change!
the default values for each query parameter are
falseso that you must selectively request additional information from the database, which means anyone using the/metricsendpoint as it works currently will stop receiving data unless they update their query fromcurl 'localhost:8080/metrics'to
curl 'localhost:8080/metrics?user_count=t&build_count=true'and include each piece of data they would like to query for.
docs
once i get approval on the structure and usage of the parameters i will create the documentation before merging