Skip to content

chore: upgrade go 1.19 #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
plyr4 merged 8 commits into from
Sep 12, 2022
Merged

chore: upgrade go 1.19 #690

plyr4 merged 8 commits into from
Sep 12, 2022

Conversation

@plyr4
Copy link
Contributor

@plyr4 plyr4 commented Sep 7, 2022 •
edited
Loading

  • upgrades Go to 1.19
  • upgrades go-swagger to v0.30.2 to include Fixes for go 1.19 go-swagger/go-swagger#2808 , required by Go 1.19
  • updates Actions to install go separately and NOT use a container, to work with docker publish v4

@codecov
Copy link

codecov bot commented Sep 7, 2022 •
edited
Loading

Codecov Report

Merging #690 (b610f26) into master (92ef555) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #690   +/-   ##
=======================================
  Coverage   55.10%   55.10%           
=======================================
  Files         201      201           
  Lines       15960    15960           
=======================================
  Hits         8794     8794           
  Misses       6788     6788           
  Partials      378      378
Impacted Files Coverage Δ
router/middleware/logger.go 95.89% <ø> (ø)

@plyr4 plyr4 marked this pull request as ready for review September 7, 2022 16:33
@plyr4 plyr4 requested a review from a team as a code owner September 7, 2022 16:33
@plyr4 plyr4 mentioned this pull request Sep 7, 2022
Closed
wass3r
wass3r approved these changes Sep 7, 2022
View reviewed changes
Copy link
Collaborator

@wass3r wass3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ecrupper
ecrupper approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@ecrupper ecrupper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plyr4 plyr4 merged commit c0abd52 into master Sep 12, 2022
@plyr4 plyr4 deleted the chore/upgrade-go branch September 12, 2022 18:42
@colindean colindean mentioned this pull request Aug 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wass3r wass3r wass3r approved these changes

@ecrupper ecrupper ecrupper approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@plyr4 @wass3r @ecrupper