-
Notifications
You must be signed in to change notification settings - Fork 30
fix(compiler): add template name to inline render #691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #691 +/- ##
==========================================
+ Coverage 54.98% 55.00% +0.01%
==========================================
Files 211 211
Lines 16014 16014
==========================================
+ Hits 8805 8808 +3
+ Misses 6831 6829 -2
+ Partials 378 377 -1
|
Collaborator
|
@rfigueroa can you help resolve the failing tests? |
ecrupper
approved these changes
Oct 3, 2022
Contributor
ecrupper
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested locally, works great. Code LGTM!
JordanSussman
approved these changes
Oct 3, 2022
wass3r
approved these changes
Oct 3, 2022
This was referenced Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change builds on top of go-vela/compiler#194 to also inject the templates name when parsing inline templates
fixes:go-vela/community#675