Skip to content

Conversation

@rfigueroa
Copy link
Contributor

This change builds on top of go-vela/compiler#194 to also inject the templates name when parsing inline templates

fixes:go-vela/community#675

@rfigueroa rfigueroa requested a review from a team as a code owner September 8, 2022 17:39
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #691 (e964e42) into main (435f63f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #691      +/-   ##
==========================================
+ Coverage   54.98%   55.00%   +0.01%     
==========================================
  Files         211      211              
  Lines       16014    16014              
==========================================
+ Hits         8805     8808       +3     
+ Misses       6831     6829       -2     
+ Partials      378      377       -1     
Impacted Files Coverage Δ
compiler/native/compile.go 62.24% <100.00%> (+0.76%) ⬆️
compiler/native/parse.go 84.61% <100.00%> (ø)
compiler/template/native/render.go 86.95% <100.00%> (ø)
compiler/template/starlark/render.go 46.10% <100.00%> (ø)

@JordanSussman
Copy link
Collaborator

@rfigueroa can you help resolve the failing tests?

Copy link
Contributor

@ecrupper ecrupper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally, works great. Code LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants