enhance(webhook): add extra debug logging at various points in workflow #697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #697 +/- ##
==========================================
- Coverage 55.05% 54.98% -0.07%
==========================================
Files 211 211
Lines 15994 16014 +20
==========================================
Hits 8805 8805
- Misses 6811 6831 +20
Partials 378 378
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
plyr4
reviewed
Sep 16, 2022
api/webhook.go
Outdated
|
|
||
| h, r, b := webhook.Hook, webhook.Repo, webhook.Build | ||
|
|
||
| logrus.Debugf("Hook generated from SCM: %v", h) |
Contributor
There was a problem hiding this comment.
how do these structs look when printed out? are they easy enough to read?
Contributor
There was a problem hiding this comment.
also leaving this here:
https://github.com/go-vela/server/blob/main/api/user.go#L75-L77
you might be able to use fields
wass3r
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes go-vela/community#657
Trying to add some extra context during the webhook processing without overlapping some of the normal debug logging