Skip to content

enhance(secrets): verify casing of orgs and repos in SCM before adding secret #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ecrupper merged 5 commits into from
Sep 27, 2022
Merged

enhance(secrets): verify casing of orgs and repos in SCM before adding secret #700

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8485106
enhance(secrets): verify casing and existence of orgs and repos in SC…
ecrupper Sep 22, 2022
ff2f36f
fix some comments
ecrupper Sep 22, 2022
f1dabe0
add clarifying comments
ecrupper Sep 23, 2022
76bed2f
ditch equalfold check since it will always be true at that point
ecrupper Sep 26, 2022
5c31e41
Merge branch 'main' into fix/repo-check-for-secrets
ecrupper Sep 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix some comments
  • Loading branch information
@ecrupper
ecrupper committed Sep 22, 2022
commit ff2f36f14cf1e50a1967a579c3108d1f959bac39
2 changes: 1 addition & 1 deletion scm/github/org.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import (
"github.com/go-vela/types/library"
)

// GetOrg gets repo information from Github.
// GetOrgName gets org name from Github.
func (c *client) GetOrgName(u *library.User, o string) (string, error) {
c.Logger.WithFields(logrus.Fields{
"org": o,
Expand Down
2 changes: 1 addition & 1 deletion scm/github/repo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ func (c *client) GetRepo(u *library.User, r *library.Repo) (*library.Repo, error
return toLibraryRepo(*repo), nil
}

// IsRepo checks to see if repo exists in GitHub.
// GetRepoName returns the name of the repository in the SCM.
func (c *client) GetRepoName(u *library.User, o string, r string) (string, error) {
c.Logger.WithFields(logrus.Fields{
"org": o,
Expand Down