Skip to content

Conversation

@ecrupper
Copy link
Contributor

Closes go-vela/community#713

Platform admins will no longer be able to pull all sensitive resources (such as secrets, repos, and users) as well as resources which have typically very large tables in the DB (builds, steps, services).

@ecrupper ecrupper self-assigned this Nov 15, 2022
@ecrupper ecrupper requested a review from a team as a code owner November 15, 2022 17:30
@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #734 (441eb1d) into main (c47375a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #734   +/-   ##
=======================================
  Coverage   54.94%   54.94%           
=======================================
  Files         211      211           
  Lines       16030    16030           
=======================================
  Hits         8808     8808           
  Misses       6845     6845           
  Partials      377      377           

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit 4846386 into main Nov 15, 2022
@ecrupper ecrupper deleted the yoink-admin-list-all-secrets branch November 15, 2022 17:40
@wass3r wass3r changed the title enhance(admin/api): remove collect all endpoints for DB resources enhance(admin/api)!: remove collect all endpoints for DB resources Nov 15, 2022
@plyr4 plyr4 changed the title enhance(admin/api)!: remove collect all endpoints for DB resources enhance(admin/api)!: remove unused admin collect all endpoints Nov 16, 2022
@plyr4 plyr4 changed the title enhance(admin/api)!: remove unused admin collect all endpoints chore(admin/api)!: remove unused admin collect all endpoints Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Secrets are not safe

4 participants