Skip to content

feat(api/log)!: support paging on GetBuildLogs #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ecrupper merged 11 commits into from
Apr 10, 2023
Merged

feat(api/log)!: support paging on GetBuildLogs #798

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
88c0df7
feat(api/log): support paging on GetBuildLogs
cognifloyd Mar 2, 2023
5e1c4b0
Merge branch 'main' into log-paging
wass3rw3rk Mar 24, 2023
9368375
Merge branch 'main' into log-paging
wass3rw3rk Mar 24, 2023
2328018
Update api/log.go
cognifloyd Mar 24, 2023
404163c
refactor(api/log): cap max per_page at 100
cognifloyd Mar 25, 2023
29e8aff
Merge branch 'main' into log-paging
wass3rw3rk Mar 27, 2023
ed5f252
enhance(api/log)!: lower default per_page to 10 from 100 (the max)
cognifloyd Mar 28, 2023
f8f03d0
Merge branch 'main' into log-paging
KellyMerrick Apr 5, 2023
3c43516
Merge branch 'main' into log-paging
wass3r Apr 6, 2023
04ba4ab
Merge branch 'main' into log-paging
cognifloyd Apr 8, 2023
9aea6af
Merge branch 'main' into log-paging
cognifloyd Apr 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor(api/log): cap max per_page at 100
  • Loading branch information
@cognifloyd
cognifloyd committed Mar 25, 2023
commit 404163ce8ca4a6269237f8b5430f9395725dcf38
4 changes: 2 additions & 2 deletions api/log.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ import (
// name: per_page
// description: How many results per page to return
// type: integer
// maximum: 500
// maximum: 100
// default: 100
// security:
// - ApiKeyAuth: []
Expand Down Expand Up @@ -113,7 +113,7 @@ func GetBuildLogs(c *gin.Context) {
}

// ensure per_page isn't above or below allowed values
perPage = util.MaxInt(1, util.MinInt(500, perPage))
perPage = util.MaxInt(1, util.MinInt(100, perPage))

// send API call to capture the list of logs for the build
l, t, err := database.FromContext(c).ListLogsForBuild(b, page, perPage)
Expand Down