chore: Delete unused /stream endpoints
#799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #799 +/- ##
==========================================
+ Coverage 56.48% 57.09% +0.60%
==========================================
Files 243 242 -1
Lines 16164 15994 -170
==========================================
Hits 9131 9131
+ Misses 6628 6458 -170
Partials 405 405 |
This was referenced Mar 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #795
Instead of refactoring the stream endpoints like in #795, this removes them completely.
These endpoints are no longer used since go-vela/worker#233
They were abandoned due to issues with load balancers closing connections. Any future streaming solution will need to handle that gracefully, which these endpoints do not do.
See the conversation here for more: #795 (review)
Follow-up to remove the endpoints from go-sdk: go-vela/sdk-go#215