Skip to content

Conversation

@ecrupper
Copy link
Contributor

There have been several cases where a build has found itself in a pending state due to some error in the webhook flow (typically around publishToQueue). These builds never make it to the queue and are still left as pending. This additional query to the metrics endpoint gives a much more accurate representation of queue size.

@ecrupper ecrupper requested a review from a team as a code owner March 31, 2023 20:17
@ecrupper ecrupper self-assigned this Mar 31, 2023
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #802 (f0095e6) into main (f8a9aa1) will decrease coverage by 0.02%.
The diff coverage is 47.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #802      +/-   ##
==========================================
- Coverage   57.11%   57.10%   -0.02%     
==========================================
  Files         242      243       +1     
  Lines       16004    16023      +19     
==========================================
+ Hits         9141     9150       +9     
- Misses       6458     6467       +9     
- Partials      405      406       +1     
Impacted Files Coverage Δ
api/metrics.go 0.00% <0.00%> (ø)
queue/redis/length.go 75.00% <75.00%> (ø)

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants