chore: add vscode project files to gitignore #837
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cognifloyd
approved these changes
May 3, 2023
Codecov Report
@@ Coverage Diff @@
## main #837 +/- ##
=======================================
Coverage 58.43% 58.43%
=======================================
Files 270 270
Lines 15636 15636
=======================================
Hits 9137 9137
Misses 6075 6075
Partials 424 424 |
wass3rw3rk
approved these changes
May 11, 2023
Member
wass3rw3rk
left a comment
wass3rw3rk
left a comment
There was a problem hiding this comment.
i'm ok with this for now, but i know gitignore.io's default setup for VSCode is a bit more lenient. i think the idea is to share useful settings/debug configuration among developers and drop everything else. we may not have anything unified today, but it might be beneficial to provide something?
see also: https://stackoverflow.com/questions/32964920/should-i-commit-the-vscode-folder-to-source-control
Contributor
Author
|
@wass3rw3rk sounds good i can extend it. (still need this PR for __debug_bin produced by the dlv extension) |
Contributor
Author
|
closing in favor of #844 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see title