Skip to content

Conversation

@ecrupper
Copy link
Contributor

@ecrupper ecrupper commented May 8, 2023

Part of the effort for go-vela/community#485

This change will give users the ability to cancel builds that are in a pending state. The server will perform the necessary updates to the database to ensure the build (and its steps/services) has the correct status. The worker will pop that item off the queue and determine whether or not it has been cancelled. In other words, rather than scan the queue searching for the item to remove, it seems like a better strategy to let the workers do the cleaning.

@ecrupper ecrupper self-assigned this May 8, 2023
@ecrupper ecrupper requested a review from a team as a code owner May 8, 2023 21:42
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #840 (11a2a13) into main (af42abe) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #840      +/-   ##
==========================================
- Coverage   57.73%   57.70%   -0.03%     
==========================================
  Files         263      263              
  Lines       15914    15922       +8     
==========================================
  Hits         9188     9188              
- Misses       6311     6319       +8     
  Partials      415      415              
Impacted Files Coverage Δ
api/build.go 1.48% <0.00%> (-0.01%) ⬇️
router/middleware/executors/executors.go 2.56% <0.00%> (-0.26%) ⬇️

cognifloyd
cognifloyd previously approved these changes May 9, 2023
@ecrupper ecrupper merged commit f99a894 into main May 10, 2023
@ecrupper ecrupper deleted the cancel-pending-builds branch May 10, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants