Skip to content

Conversation

@jbrockopp
Copy link
Contributor

@jbrockopp jbrockopp commented Jun 1, 2023

Dependent on #869

This change adds a NewResources() function to the database agnostic engine{} type introduced in #868.

This function will be used to create all resource based engines for the configured database.

The logic for this function was copied from the duplicate code we already have in both supported drivers:

@jbrockopp jbrockopp self-assigned this Jun 1, 2023
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #870 (14d3a0f) into main (e4bfa4e) will decrease coverage by 0.03%.
The diff coverage is 69.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #870      +/-   ##
==========================================
- Coverage   72.09%   72.07%   -0.03%     
==========================================
  Files         311      312       +1     
  Lines       12953    13051      +98     
==========================================
+ Hits         9339     9407      +68     
- Misses       3168     3188      +20     
- Partials      446      456      +10     
Impacted Files Coverage Δ
database/resource.go 69.38% <69.38%> (ø)

@jbrockopp jbrockopp marked this pull request as ready for review June 5, 2023 20:57
@jbrockopp jbrockopp requested a review from a team as a code owner June 5, 2023 20:57
@jbrockopp jbrockopp added the feature Indicates a new feature label Jun 6, 2023
@plyr4 plyr4 merged commit e8bdb15 into main Jun 7, 2023
@plyr4 plyr4 deleted the feature/database/engine_resources branch June 7, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Indicates a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants