refactor(templates): use yaml for tests instead of base64 encoded json #881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordanSussman
commented
Jun 11, 2023
| "username": "octocat", | ||
| "items": []interface{}{ | ||
| map[interface{}]interface{}{string("path"): string("docker"), string("source"): string("secret/docker")}, | ||
| map[interface{}]interface{}{"path": "docker", "source": "secret/docker"}, |
Collaborator
Author
There was a problem hiding this comment.
The string is redundant since Go is able to infer that anything within "" is already a string.
Codecov Report
@@ Coverage Diff @@
## main #881 +/- ##
=======================================
Coverage 71.28% 71.28%
=======================================
Files 303 303
Lines 12374 12374
=======================================
Hits 8821 8821
Misses 3127 3127
Partials 426 426 |
ecrupper
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from using base64 encoded files to straight yaml files with the
convertFileToGithubResponsefunction.This changes makes it much easier to understand what the underlying file content is since you no longer need to do something like
echo -n 'base64 encoded content' | base64 -D.