-
Notifications
You must be signed in to change notification settings - Fork 30
fix(schedules): updated_at automatically updates to any change to row #894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #894 +/- ##
=======================================
Coverage 71.47% 71.48%
=======================================
Files 304 304
Lines 12436 12438 +2
=======================================
+ Hits 8889 8891 +2
Misses 3116 3116
Partials 431 431
|
jbrockopp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I'm good the boolean approach
jbrockopp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wass3rw3rk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
wass3rw3rk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Existing schedule:
{ "id": 1, "repo_id": 1, "active": true, "name": "hourly", "entry": "0 * * * *", "created_at": 1641314085, "created_by": "octokitty", "updated_at": 1641314085, "updated_by": "octokitty", "scheduled_at": 0 }Old:
New:
GORM auto updates
updated_at. This change ensures that that field is still relevant.RFC: separate DB function altogether, or will this boolean be fine?