Skip to content

Conversation

@ecrupper
Copy link
Contributor

When leveraging vela validate pipeline --template --template-file exampleOne:one.yml,exampleTwo:two.yml in a nested template sense (exampleTwo is called within exampleOne), the current implementation of local template retrieval can't handle that.

By adding local templates to the engine itself, we can access the provided info at any time during compilation, allowing proper local retrieval deep within a template chain.

@ecrupper ecrupper requested a review from a team as a code owner July 25, 2023 17:38
@ecrupper ecrupper self-assigned this Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #916 (e219b5e) into main (41fdfd1) will increase coverage by 0.10%.
The diff coverage is 34.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #916      +/-   ##
==========================================
+ Coverage   71.37%   71.47%   +0.10%     
==========================================
  Files         304      304              
  Lines       12466    12454      -12     
==========================================
+ Hits         8897     8901       +4     
+ Misses       3134     3120      -14     
+ Partials      435      433       -2     
Files Changed Coverage Δ
compiler/native/expand.go 71.23% <0.00%> (-2.96%) ⬇️
compiler/native/compile.go 67.91% <100.00%> (+4.25%) ⬆️
compiler/native/native.go 86.27% <100.00%> (+0.56%) ⬆️

wass3rw3rk
wass3rw3rk previously approved these changes Jul 25, 2023
plyr4
plyr4 previously approved these changes Jul 25, 2023
@ecrupper ecrupper dismissed stale reviews from plyr4 and wass3rw3rk via e219b5e July 25, 2023 19:09
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants