enhance: use consistent variable aliases for queue signing keys #946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #946 +/- ##
=======================================
Coverage 70.83% 70.83%
=======================================
Files 311 311
Lines 12849 12849
=======================================
Hits 9101 9101
Misses 3283 3283
Partials 465 465 |
timhuynh94
approved these changes
Aug 29, 2023
ecrupper
approved these changes
Aug 29, 2023
ecrupper
pushed a commit
that referenced
this pull request
Aug 30, 2023
ecrupper
added a commit
that referenced
this pull request
Aug 31, 2023
* Increase Starlark execution limit, abstract limit resolver 5,000 was too few to enable the example added to the testdata to work, so was 6,000. I chose 7,500 arbitrarily after a test at 10,000 and both worked. In the long term, this should probably be configurable so as not to require recompilation. For now, this kicks the can down the road while allowing this build matrix use case to exist. * refactor(db): return user on created and updated (#935) * enhance(starlark): make execution step limit configurable * remove compose configuration * make execlimit part of test struct * update limit for Render * enhance: use consistent variable aliases (#946) * remove helper function to get limit --------- Co-authored-by: Colin Dean <[email protected]> Co-authored-by: Colin Dean <[email protected]> Co-authored-by: dave vader <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i thought i included these variables in my last tweak PR but apparently not. i noticed while writing the docs.