This repository was archived by the owner on Aug 5, 2025. It is now read-only.
feat(secrets): adding logging mask constant #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #220 +/- ##
=======================================
Coverage 96.71% 96.71%
=======================================
Files 53 53
Lines 5595 5595
=======================================
Hits 5411 5411
Misses 137 137
Partials 47 47 |
plyr4
approved these changes
Dec 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Jenkins and Drone both manage to mask secrets in their logs using the mask
***. I understand there may be concern of redundancy with theSecretMaskconstant, so I'm open to discussion on whether we should use that instead. However, it may be nice to have that consistency with other CI/CD platforms.Usage in this PR