This repository was archived by the owner on Aug 5, 2025. It is now read-only.
chore: remove number field from Pipeline{} #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #248 +/- ##
==========================================
+ Coverage 97.07% 97.11% +0.03%
==========================================
Files 56 56
Lines 6258 6239 -19
==========================================
- Hits 6075 6059 -16
+ Misses 134 132 -2
+ Partials 49 48 -1
|
cognifloyd
approved these changes
Apr 18, 2022
wass3r
approved these changes
Apr 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the effort for go-vela/community#460
Based off of #223
This change removes the
Numberfield from thePipeline{}type which was previously introduced in the above PR.I found a way to add support for
pipelinesin the Vela system without requiring anumbercounting system.This has been propagated to the server within go-vela/server#626.