Skip to content

Conversation

@GregoryDosh
Copy link
Contributor

This includes a couple of changes which allows for pinning the version of the OpenSSH and SSHPass binaries. It also includes this information in the help and version information for each plugin. It includes integration tests to make sure versions aren't unknown and that they're set in the built docker containers as well.

There are probably things to be cleaned up or pulled into common functionality at some point, but for now this should allow for pinning the version information in the Makefile only and then all the rest should be pulled in automatically.

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #11 (2644c92) into main (5a0a60f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #11   +/-   ##
=======================================
  Coverage   93.40%   93.40%           
=======================================
  Files           3        3           
  Lines         288      288           
=======================================
  Hits          269      269           
  Misses         13       13           
  Partials        6        6           

@GregoryDosh GregoryDosh requested a review from a team February 16, 2022 17:22
Comment on lines +13 to +14
OPENSSH_VERSION=8.8_p1-r1
SSHPASS_VERSION=1.09-r0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can/should combine this with https://docs.renovatebot.com/modules/datasource/#repology-datasource to configure renovate to be aware of the versioning to give us a kick in the butt when there are patches/fixes and such? in the same token, i have never used that setup so not sure how well it works.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh that's cool, didn't know about that feature. I'll take a look at it tomorrow to see about integrating this. My goal tomorrow/this-week is to get a tagged release and to start I just wanted pinned versions, but something longer term would be like this. So when I merge this PR I'll open a couple of issues to track things like this and the movement away from depending on vela-kaniko for anything.

@GregoryDosh GregoryDosh merged commit 91b9234 into main Feb 17, 2022
@GregoryDosh GregoryDosh deleted the feat/set-binary-versions branch February 17, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants