Skip to content

fix(docker): pulling images without output #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wass3r merged 1 commit into from
Dec 15, 2021
Merged

fix(docker): pulling images without output #253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(docker): pulling images without output
  • Loading branch information
@jbrockopp
jbrockopp committed Dec 15, 2021
commit 871c89ea4a20a4d235df763f81bbb7203c06069d
7 changes: 7 additions & 0 deletions runtime/docker/image.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"context"
"fmt"
"io"
"io/ioutil"
"os"
"strings"

Expand Down Expand Up @@ -51,6 +52,12 @@ func (c *client) CreateImage(ctx context.Context, ctn *pipeline.Container) error
if err != nil {
return err
}
} else {
// discard output from image pull
_, err = io.Copy(ioutil.Discard, reader)
if err != nil {
return err
}
}

return nil
Expand Down