Skip to content

feat(kubernetes): Add PipelinePodsTemplate CRD to define worker-specific Pod defaults for Kubernetes Runtime #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wass3r merged 25 commits into from
Apr 7, 2022
Merged

feat(kubernetes): Add PipelinePodsTemplate CRD to define worker-specific Pod defaults for Kubernetes Runtime #294

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
9daffd1
feat(k8s): Define PipelinePodsTemplate CRD
cognifloyd Mar 12, 2022
19a183a
chore: Add crd generation targets to Makefile
cognifloyd Mar 18, 2022
718d9bd
chore: Generate client for PipelinePodsTemplate CRD
cognifloyd Mar 12, 2022
ed28cf6
chore: Generate PipelinePodsTemplate CRD manifest
cognifloyd Mar 21, 2022
5dcb8a3
feat(k8s): Add PipelinePodsTemplate loading opts
cognifloyd Mar 17, 2022
7d7f1e9
feat(k8s): Get PipelinePodsTemplate from k8s API
cognifloyd Mar 18, 2022
020421a
feat(k8s): Get defaults from PipelinePodTemplate
cognifloyd Mar 17, 2022
7c261a2
chore: Add tests for runtime WithPodsTemplate opt
cognifloyd Mar 23, 2022
f5837d7
chore: Add tests for runtime WithPodsTemplate opt (failure path)
cognifloyd Mar 23, 2022
040cbae
chore: Extend k8s SetupBuild test to use WithPodsTemplate
cognifloyd Mar 23, 2022
f8b4d5f
chore: Extend k8s SetupBuild test PipelinePodsTemplate missing in k8s
cognifloyd Mar 23, 2022
1552e6e
chore: Extend k8s SetupBuild test with mocked PipelinePodsTemplate in…
cognifloyd Mar 23, 2022
6703202
fix(kubernetes): use sigs.k8s.io/yaml instead of buildkite/yaml
cognifloyd Mar 23, 2022
77ed714
feat(kubernetes): ensure local PipelinePodsTemplate YAML is valid
cognifloyd Mar 23, 2022
5558f17
Merge branch 'master' into k8s-pods-templates
cognifloyd Mar 23, 2022
e7ca84a
chore: test ignoring k8s labels from PipelinePodsTemplate
cognifloyd Mar 23, 2022
3ac92fb
chore: test CRD with DNS or node selection
cognifloyd Mar 23, 2022
504c15f
refactor(k8s): simplify setting container.SecurityContext
cognifloyd Mar 23, 2022
2574d97
chore(kubernetes): ensure PipelinePodsTemplate contents get into Pod …
cognifloyd Mar 23, 2022
eabfd5b
chore(kubernetes): test SetupContainer with privileged container
cognifloyd Mar 23, 2022
2e6d35b
chore: satisfy lint
cognifloyd Mar 23, 2022
060d1f8
chore: Add instructional comments with links to docs
cognifloyd Mar 24, 2022
8bdca0b
Merge branch 'master' into k8s-pods-templates
cognifloyd Mar 24, 2022
097973a
Adjust comment location
cognifloyd Apr 4, 2022
156980a
chore: update opts FilePath to use _ over -
cognifloyd Apr 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor(k8s): simplify setting container.SecurityContext
  • Loading branch information
@cognifloyd
cognifloyd committed Mar 23, 2022
commit 504c15f15001f6d559ede9a786e7fd8ab9f2e66a
4 changes: 1 addition & 3 deletions runtime/kubernetes/container.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,9 +168,7 @@ func (c *client) SetupContainer(ctx context.Context, ctn *pipeline.Container) er
return err
}

container.SecurityContext = &v1.SecurityContext{
Privileged: &privileged,
}
container.SecurityContext.Privileged = &privileged
}

if c.PipelinePodTemplate != nil && c.PipelinePodTemplate.Spec.Container != nil {
Expand Down