Skip to content

Conversation

@cognifloyd
Copy link
Member

These are already silenced in several other places. So, let's get reviewdog full-review to stop complaining.

@cognifloyd cognifloyd requested a review from a team as a code owner April 14, 2022 17:46
@cognifloyd cognifloyd added the enhancement Indicates an improvement to a feature label Apr 14, 2022
@cognifloyd cognifloyd self-assigned this Apr 14, 2022
@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #305 (b73d804) into master (c091a57) will not change coverage.
The diff coverage is n/a.

❗ Current head b73d804 differs from pull request most recent head c091a57. Consider uploading reports for the commit c091a57 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #305   +/-   ##
=======================================
  Coverage   79.77%   79.77%           
=======================================
  Files          67       67           
  Lines        4958     4958           
=======================================
  Hits         3955     3955           
  Misses        859      859           
  Partials      144      144           

@cognifloyd
Copy link
Member Author

🎉 This makes reviewdog / full-revew green!

Copy link
Collaborator

@wass3r wass3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm. there are no changes ?

@cognifloyd
Copy link
Member Author

I targeted the wrong branch. dang it.

@cognifloyd
Copy link
Member Author

@wass3r Please see #307 instead. 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Indicates an improvement to a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants