Skip to content

feat(stage): stages fail independently when continue is set to true #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ecrupper merged 13 commits into from
Dec 13, 2022
Merged

feat(stage): stages fail independently when continue is set to true #318

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d0a4110
first draft
ecrupper Apr 15, 2022
72e87d1
changing dependent to continue and ditching print statements
ecrupper Apr 20, 2022
f95d467
Merge branch 'main' into i546/handle-independent-stages
ecrupper Dec 9, 2022
7b118d6
changing continue to independent and linter work
ecrupper Dec 9, 2022
c573b96
Merge branch 'main' into i546/handle-independent-stages
wass3r Dec 9, 2022
850fb82
adding new types in go mod
ecrupper Dec 9, 2022
c60b4e1
Merge branch 'i546/handle-independent-stages' of github.com:go-vela/w…
ecrupper Dec 9, 2022
a0cc8ac
Merge branch 'main' into i546/handle-independent-stages
ecrupper Dec 9, 2022
08a0ba2
go mod tidy
ecrupper Dec 9, 2022
0643d02
Merge branch 'i546/handle-independent-stages' of github.com:go-vela/w…
ecrupper Dec 9, 2022
888f0ba
Merge branch 'main' into i546/handle-independent-stages
ecrupper Dec 13, 2022
d0e39e5
adding additional stop check in stage loop and more comments
ecrupper Dec 13, 2022
50a7db0
Merge branch 'main' into i546/handle-independent-stages
ecrupper Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
changing continue to independent and linter work
  • Loading branch information
@ecrupper
ecrupper committed Dec 9, 2022
commit 7b118d6516e4108bf337f15ba6e2b9a895ec6da6
5 changes: 4 additions & 1 deletion executor/linux/stage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,15 +118,17 @@ func (c *client) ExecStage(ctx context.Context, s *pipeline.Stage, m *sync.Map)
}()

logger.Debug("starting execution of stage")

stop := false

// execute the steps for the stage
for _, _step := range s.Steps {
// check if the step should be skipped
//
// https://pkg.go.dev/github.com/go-vela/worker/internal/step#Skip
ruleset := _step.Ruleset

if !stop && s.Continue {
if !stop && s.Independent {
ruleset.If.Parallel = true
} else {
ruleset.If.Parallel = false
Expand All @@ -151,6 +153,7 @@ func (c *client) ExecStage(ctx context.Context, s *pipeline.Stage, m *sync.Map)
if err != nil {
return fmt.Errorf("unable to exec step %s: %w", _step.Name, err)
}

if _step.ExitCode != 0 && !_step.Ruleset.Continue {
stop = true
}
Expand Down
12 changes: 6 additions & 6 deletions executor/linux/stage_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,8 +317,8 @@ func TestLinux_ExecStage(t *testing.T) {
name: "basic stage",
failure: false,
stage: &pipeline.Stage{
Continue: true,
Name: "echo",
Independent: true,
Name: "echo",
Steps: pipeline.ContainerSlice{
{
ID: "github_octocat_1_echo_echo",
Expand All @@ -336,8 +336,8 @@ func TestLinux_ExecStage(t *testing.T) {
name: "stage with step container with image not found",
failure: true,
stage: &pipeline.Stage{
Name: "echo",
Continue: true,
Name: "echo",
Independent: true,
Steps: pipeline.ContainerSlice{
{
ID: "github_octocat_1_echo_echo",
Expand All @@ -355,8 +355,8 @@ func TestLinux_ExecStage(t *testing.T) {
name: "stage with step container with bad number",
failure: true,
stage: &pipeline.Stage{
Name: "echo",
Continue: true,
Name: "echo",
Independent: true,
Steps: pipeline.ContainerSlice{
{
ID: "github_octocat_1_echo_echo",
Expand Down