Skip to content

fix(ci): Fix silent failures in GHA reviewdog workflow #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wass3r merged 5 commits into from
Apr 22, 2022
Merged

fix(ci): Fix silent failures in GHA reviewdog workflow #319

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c6e2fc4
fix gha reviewdog workflow so it actually uses go 1.17
cognifloyd Apr 21, 2022
b9235cc
fix(ci): use go 1.17.9 in reviewdog
cognifloyd Apr 21, 2022
b545e1a
fix: drop golang container since reviewdog always installs go
cognifloyd Apr 21, 2022
b27926d
fix(ci): make golangci-lint verbose
cognifloyd Apr 21, 2022
477e561
Merge branch 'master' into fix-reviewdog
wass3r Apr 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(ci): make golangci-lint verbose
  • Loading branch information
@cognifloyd
cognifloyd committed Apr 21, 2022
commit b27926d42c65da867489eb31561c7de646008b6a
4 changes: 2 additions & 2 deletions .github/workflows/reviewdog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
with:
github_token: ${{ secrets.github_token }}
go_version: 1.17.9
golangci_lint_flags: "--config=.golangci.yml"
golangci_lint_flags: "--config=.golangci.yml --verbose"
fail_on_error: true
filter_mode: diff_context
reporter: github-pr-review
Expand All @@ -38,6 +38,6 @@ jobs:
with:
github_token: ${{ secrets.github_token }}
go_version: 1.17.9
golangci_lint_flags: "--config=.golangci.yml"
golangci_lint_flags: "--config=.golangci.yml --verbose"
fail_on_error: false
filter_mode: nofilter