Skip to content

fix: revert log streaming commit #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wass3r merged 3 commits into from
Dec 12, 2022
Merged

fix: revert log streaming commit #409

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a25320a
fix: revert log streaming commit
wass3r Dec 12, 2022
0ddb8f0
remove commented code
wass3r Dec 12, 2022
bf8a589
fix header
wass3r Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove commented code
  • Loading branch information
@wass3r
wass3r committed Dec 12, 2022
commit 0ddb8f0ac2f8778d90c4633b098afb4afa2fd801
15 changes: 1 addition & 14 deletions cmd/vela-worker/exec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
// Copyright (c) 2022 Target Brands, Inc. All rights reserved.
//
// Use of this source code is governed by the LICENSE file in this repository.
// Copyright (c) 2022 Target Brands, Inc. All rights reserved. Use of this source code is governed by the LICENSE file in this repository.

package main

import (
"context"
// "sync"
"time"

"github.com/go-vela/worker/executor"
Expand Down Expand Up @@ -110,13 +107,7 @@ func (w *Worker) exec(index int) error {
timeoutCtx, timeout := context.WithTimeout(buildCtx, t)
defer timeout()

// This WaitGroup delays calling DestroyBuild until the StreamBuild goroutine finishes.
// var wg sync.WaitGroup

defer func() {
// if exec() exits before starting StreamBuild, this returns immediately.
// wg.Wait()

logger.Info("destroying build")

// destroy the build with the executor (pass a background
Expand Down Expand Up @@ -145,12 +136,8 @@ func (w *Worker) exec(index int) error {
return nil
}

// add StreamBuild goroutine to WaitGroup
// wg.Add(1)

// log/event streaming uses buildCtx so that it is not subject to the timeout.
go func() {
// defer wg.Done()
logger.Info("streaming build logs")
// execute the build with the executor
err = _executor.StreamBuild(buildCtx)
Expand Down