Skip to content

refactor(executor tests): Make runtime a test arg #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
plyr4 merged 13 commits into from
Jan 23, 2023
Merged

refactor(executor tests): Make runtime a test arg #418

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
22ab9d6
test: use pipeline-specific runtime instances
cognifloyd Oct 6, 2022
1a21676
test: Add test.runtime to executor build tests
cognifloyd Oct 6, 2022
58f7f70
update name of EnforceTrustedRepos test
cognifloyd Jan 20, 2023
e05e385
test: Create runtime for each executor build test
cognifloyd Oct 6, 2022
44a0233
Fix import
cognifloyd Jan 20, 2023
0643d7f
test: Drop runtime assumption for executor opts tests
cognifloyd Oct 4, 2022
8f70120
test: Drop docker runtime assumption for secrets tests
cognifloyd Oct 4, 2022
97cb3a2
test: prepare for test specific pod in executor test
cognifloyd Oct 6, 2022
7394802
test: drop runtime assumption baseline for Create funcs
jbrockopp Oct 4, 2022
a082185
test: adjust runtime assumption for service tests
JordanSussman Oct 5, 2022
4bace56
test: adjust runtime assumption for stages
jbrockopp Oct 4, 2022
dc8e7f2
test: Adjust runtime assumption in step tests
cognifloyd Oct 4, 2022
285411f
add some missing constants
cognifloyd Jan 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: Drop runtime assumption for executor opts tests
  • Loading branch information
@cognifloyd
cognifloyd committed Jan 20, 2023
commit 0643d7fc2c068dc2dd8587c5aa5bb99c21b32499
8 changes: 4 additions & 4 deletions executor/linux/opts_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,7 +480,7 @@ func TestLinux_Opt_WithRepo(t *testing.T) {

func TestLinux_Opt_WithRuntime(t *testing.T) {
// setup types
_runtime, err := docker.NewMock()
_docker, err := docker.NewMock()
if err != nil {
t.Errorf("unable to create docker runtime engine: %v", err)
}
Expand All @@ -494,7 +494,7 @@ func TestLinux_Opt_WithRuntime(t *testing.T) {
{
name: "docker runtime",
failure: false,
runtime: _runtime,
runtime: _docker,
},
{
name: "nil runtime",
Expand Down Expand Up @@ -522,8 +522,8 @@ func TestLinux_Opt_WithRuntime(t *testing.T) {
t.Errorf("WithRuntime returned err: %v", err)
}

if !reflect.DeepEqual(_engine.Runtime, _runtime) {
t.Errorf("WithRuntime is %v, want %v", _engine.Runtime, _runtime)
if !reflect.DeepEqual(_engine.Runtime, test.runtime) {
t.Errorf("WithRuntime is %v, want %v", _engine.Runtime, test.runtime)
}
})
}
Expand Down