Skip to content

enhance(executor tests): Add test helpers to generate test Pods #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ecrupper merged 9 commits into from
Feb 20, 2023
Merged

enhance(executor tests): Add test helpers to generate test Pods #424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5e8c661
test: add kubernetes baseline for Create funcs
jbrockopp Oct 4, 2022
08bafff
test: add kubernetes runtime for stages
jbrockopp Oct 4, 2022
97922d3
test: prepare for test specific pod in executor test
cognifloyd Oct 6, 2022
87615b2
test: add testPod helper method
cognifloyd Oct 6, 2022
39c1b1f
test: add testPodFor(pipeline) helper method
cognifloyd Oct 6, 2022
027847c
test: mark secret containers terminated in test Pods
cognifloyd Oct 6, 2022
b5a183e
test: use pipeline-specific runtime instances
cognifloyd Oct 6, 2022
00263b0
test: Create runtime for each executor build test
cognifloyd Oct 6, 2022
2d560a5
test: Adds several new test helpers.
cognifloyd Oct 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 43 additions & 1 deletion executor/linux/build_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ import (
"testing"
"time"

v1 "k8s.io/api/core/v1"

"github.com/gin-gonic/gin"
"github.com/go-vela/sdk-go/vela"
"github.com/go-vela/server/compiler/native"
Expand All @@ -22,6 +24,7 @@ import (
"github.com/go-vela/worker/internal/message"
"github.com/go-vela/worker/runtime"
"github.com/go-vela/worker/runtime/docker"
"github.com/go-vela/worker/runtime/kubernetes"
"github.com/sirupsen/logrus"
logrusTest "github.com/sirupsen/logrus/hooks/test"
"github.com/urfave/cli/v2"
Expand Down Expand Up @@ -121,6 +124,12 @@ func TestLinux_CreateBuild(t *testing.T) {
var _runtime runtime.Engine

switch test.runtime {
case constants.DriverKubernetes:
_pod := testPodFor(_pipeline)
_runtime, err = kubernetes.NewMock(_pod)
if err != nil {
t.Errorf("unable to create kubernetes runtime engine: %v", err)
}
case constants.DriverDocker:
_runtime, err = docker.NewMock()
if err != nil {
Expand Down Expand Up @@ -1083,6 +1092,12 @@ func TestLinux_PlanBuild(t *testing.T) {
var _runtime runtime.Engine

switch test.runtime {
case constants.DriverKubernetes:
_pod := testPodFor(_pipeline)
_runtime, err = kubernetes.NewMock(_pod)
if err != nil {
t.Errorf("unable to create kubernetes runtime engine: %v", err)
}
case constants.DriverDocker:
_runtime, err = docker.NewMock()
if err != nil {
Expand Down Expand Up @@ -1281,6 +1296,12 @@ func TestLinux_AssembleBuild(t *testing.T) {
var _runtime runtime.Engine

switch test.runtime {
case constants.DriverKubernetes:
_pod := testPodFor(_pipeline)
_runtime, err = kubernetes.NewMock(_pod)
if err != nil {
t.Errorf("unable to create kubernetes runtime engine: %v", err)
}
case constants.DriverDocker:
_runtime, err = docker.NewMock()
if err != nil {
Expand Down Expand Up @@ -1432,9 +1453,18 @@ func TestLinux_ExecBuild(t *testing.T) {
// Docker uses _ while Kubernetes uses -
_pipeline = _pipeline.Sanitize(test.runtime)

var _runtime runtime.Engine
var (
_runtime runtime.Engine
_pod *v1.Pod
)
Comment on lines +1456 to +1459
Copy link
Member Author

@cognifloyd cognifloyd Feb 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unlike the other tests, this test will need access to _pod after initialize the k8s runtime.


switch test.runtime {
case constants.DriverKubernetes:
_pod = testPodFor(_pipeline)
_runtime, err = kubernetes.NewMock(_pod)
if err != nil {
t.Errorf("unable to create kubernetes runtime engine: %v", err)
}
case constants.DriverDocker:
_runtime, err = docker.NewMock()
if err != nil {
Expand Down Expand Up @@ -1818,6 +1848,12 @@ func TestLinux_StreamBuild(t *testing.T) {
var _runtime runtime.Engine

switch test.runtime {
case constants.DriverKubernetes:
_pod := testPodFor(_pipeline)
_runtime, err = kubernetes.NewMock(_pod)
if err != nil {
t.Errorf("unable to create kubernetes runtime engine: %v", err)
}
case constants.DriverDocker:
_runtime, err = docker.NewMock()
if err != nil {
Expand Down Expand Up @@ -2024,6 +2060,12 @@ func TestLinux_DestroyBuild(t *testing.T) {
var _runtime runtime.Engine

switch test.runtime {
case constants.DriverKubernetes:
_pod := testPodFor(_pipeline)
_runtime, err = kubernetes.NewMock(_pod)
if err != nil {
t.Errorf("unable to create kubernetes runtime engine: %v", err)
}
case constants.DriverDocker:
_runtime, err = docker.NewMock()
if err != nil {
Expand Down
Loading