Skip to content

fix: cleanup of build resources #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kneal merged 2 commits into from
Feb 27, 2020
Merged

fix: cleanup of build resources #64

kneal merged 2 commits into from
Feb 27, 2020

Conversation

@jbrockopp
Copy link
Contributor

@jbrockopp jbrockopp commented Feb 27, 2020

No description provided.

@jbrockopp jbrockopp added the bug Indicates a bug label Feb 27, 2020
@jbrockopp jbrockopp requested a review from a team as a code owner February 27, 2020 14:23
@jbrockopp jbrockopp self-assigned this Feb 27, 2020
kneal
kneal previously approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@kneal kneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐬

wass3r
wass3r previously approved these changes Feb 27, 2020
View reviewed changes
@jbrockopp jbrockopp dismissed stale reviews from wass3r and kneal via 5d22c51 February 27, 2020 14:38
kneal
kneal approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@kneal kneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐬

@jbrockopp jbrockopp closed this Feb 27, 2020
@jbrockopp jbrockopp reopened this Feb 27, 2020
@codecov
Copy link

codecov bot commented Feb 27, 2020 •
edited
Loading

Codecov Report

Merging #64 into master will not change coverage.
The diff coverage is 14.28%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #64   +/-   ##
=======================================
  Coverage   67.67%   67.67%           
=======================================
  Files          22       22           
  Lines        1120     1120           
=======================================
  Hits          758      758           
  Misses        236      236           
  Partials      126      126
Impacted Files Coverage Δ
executor/linux/build.go 54.38% <0%> (ø) ⬆️
runtime/docker/container.go 74.28% <100%> (ø) ⬆️

@kneal kneal merged commit 419a170 into master Feb 27, 2020
@kneal kneal deleted the fix/build/cleanup branch February 27, 2020 17:32
@jbrockopp jbrockopp mentioned this pull request Apr 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wass3r wass3r wass3r approved these changes

@kneal kneal kneal approved these changes

Assignees

@jbrockopp jbrockopp

Labels

bug Indicates a bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jbrockopp @wass3r @kneal