Skip to content

core: store passwords as authenticator devices - #24325

Open
dominic-r wants to merge 1 commit into
mainfrom
dominic/password-device
Open

core: store passwords as authenticator devices#24325
dominic-r wants to merge 1 commit into
mainfrom
dominic/password-device

Conversation

@dominic-r

@dominic-r dominic-r commented Jul 23, 2026

Copy link
Copy Markdown
Member

Passwords currently live as fields on the User model, which prevents password-specific authenticator state and policy from sharing the device model used by other authenticators. This moves local password hashes and change timestamps into a PasswordDevice owned by the password stage, while keeping Django's password APIs as integration adapters and excluding password devices from MFA discovery.

Copilot AI lite review requested due to automatic review settings July 23, 2026 16:08
@dominic-r
dominic-r requested review from a team as code owners July 23, 2026 16:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@dominic-r
dominic-r marked this pull request as draft July 23, 2026 16:09
@dominic-r dominic-r self-assigned this Jul 23, 2026
@dominic-r dominic-r added this to the Release 2026.11.0: Required milestone Jul 23, 2026
@netlify

netlify Bot commented Jul 23, 2026

Copy link
Copy Markdown

Deploy Preview for authentik-integrations ready!

Name Link
🔨 Latest commit b168406
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/6a75f07624d51e0008ab9cb0
😎 Deploy Preview https://deploy-preview-24325--authentik-integrations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jul 23, 2026

Copy link
Copy Markdown

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit b168406
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/6a75f07628a9e80008cbfd7b
😎 Deploy Preview https://deploy-preview-24325--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.18072% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.73%. Comparing base (b96f8b1) to head (b168406).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
authentik/core/models.py 86.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24325      +/-   ##
==========================================
- Coverage   91.37%   90.73%   -0.65%     
==========================================
  Files        1137     1137              
  Lines       71591    71664      +73     
  Branches     3875     3875              
==========================================
- Hits        65416    65024     -392     
- Misses       6140     6605     +465     
  Partials       35       35              
Flag Coverage Δ
conformance 34.83% <46.98%> (+0.01%) ⬆️
e2e ?
integration 31.42% <45.78%> (+0.01%) ⬆️
rust 38.89% <ø> (ø)
unit 93.03% <95.18%> (+0.92%) ⬆️
unit-migrate 93.06% <95.18%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@dominic-r
dominic-r force-pushed the dominic/password-device branch from 23fdf85 to 75e3a87 Compare August 5, 2026 23:07
Copilot AI review requested due to automatic review settings August 5, 2026 23:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@dominic-r
dominic-r marked this pull request as ready for review August 5, 2026 23:07
@dominic-r
dominic-r removed request for a team August 5, 2026 23:07
Comment thread authentik/core/models.py
def __str__(self):
return self.username

def save(self, *args, **kwargs):
Copilot AI review requested due to automatic review settings August 5, 2026 23:19
@dominic-r
dominic-r force-pushed the dominic/password-device branch from 75e3a87 to f4aa26e Compare August 5, 2026 23:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-f4aa26e442e0b349ae73e29e174e49e544a422f2
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-f4aa26e442e0b349ae73e29e174e49e544a422f2

Afterwards, run the upgrade commands from the latest release notes.

Copilot AI review requested due to automatic review settings August 7, 2026 14:49
@dominic-r
dominic-r force-pushed the dominic/password-device branch from f4aa26e to b168406 Compare August 7, 2026 14:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants