Skip to content

providers/oauth2: launch url: if URL parsing fails, return no launch URL #5918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 9, 2023
Merged

providers/oauth2: launch url: if URL parsing fails, return no launch URL #5918

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d11a2b5
providers/oauth2: launch url: if URL parsing fails, return no launch URL
rissson Jun 9, 2023
dbfec08
add test
BeryJu Jun 9, 2023
3a07120
only get provider launch URL when no url is set
BeryJu Jun 9, 2023
9a5871f
only catch value error
BeryJu Jun 9, 2023
f0d99fe
format
BeryJu Jun 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
providers/oauth2: launch url: if URL parsing fails, return no launch URL 
Signed-off-by: Marc 'risson' Schmitt <[email protected]>
  • Loading branch information
@rissson
rissson committed Jun 9, 2023
commit d11a2b52b70938ee960275edcd07dd458772e04c
7 changes: 5 additions & 2 deletions authentik/providers/oauth2/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,8 +251,11 @@ def launch_url(self) -> Optional[str]:
if self.redirect_uris == "":
return None
main_url = self.redirect_uris.split("\n", maxsplit=1)[0]
launch_url = urlparse(main_url)._replace(path="")
return urlunparse(launch_url)
try:
launch_url = urlparse(main_url)._replace(path="")
return urlunparse(launch_url)
except ValueError:
return None

@property
def component(self) -> str:
Expand Down