Change Version Control bottom dock to EditorDock #113454
Open
+25
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
commented
Dec 2, 2025
17 tasks
Calinou
reviewed
Dec 2, 2025
Member
Calinou
left a comment
Calinou
left a comment
There was a problem hiding this comment.
Tested locally, I can see the docks in the list but they don't show up at the bottom/sides of the editor, nor as floating windows:
No errors appear in the Output panel or terminal.
I have https://github.com/godotengine/godot-git-plugin/releases/latest downloaded and set up in a project.
Member
Author
|
What happens when you select the menu option? Can you send your |
Member
Author
|
Well for the record, I can't reproduce this issue. The docks appear fine in my case. Can anyone else reproduce this problem? Is it really caused by this PR? |
Contributor
|
I think the Commit dock should get another icon, probably something like below (just a screenshot), as it represents not a tree but single commit |
Member
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #113024
Seems like we have 2 Version Control docks and EditorDock was already being used in that file 🤔
Which unfortunately means that both docks use the same icon, which will be a problem if they will be able to share a slot (right now they can't). Suggestions for new icon welcome, I considered just flipping the existing one.
Also the new dock is global. The plugin adds/removes the dock when necessary and it's always visible, so I guess that's fine.
EDIT:
Yeah...