Fix replace parent node and paste child nodes then move cause crash

[xuhuisheng]

• Fixes: Editor crashed when moving multiple pasted nodes after changing the target(parent) node‘s type #113453

Issue Descripion

As described in #113453, if we first change parent node type, then paste child nodes, then move nodes in editor. We will attempt to move the invalid nodes from before the changes.

Solution

We can set pending_click_select = nullptr in paste_nodes() to prevent using invalid node.

Edited: We should clean tree_clicked = false after replace_node(), then later mouse click event won't select node by mistake.

replace-paste-move-crash.webm

Explaination

When we execute "change type", we click mouse right key to display context menu, which will trigger input() to mark tree_clicked = true and save pending_click_select = current_node.

godot/editor/docks/scene_tree_dock.cpp

Lines 148 to 152 in 9f5309a

	if (mb->is_pressed() && tree->get_rect().has_point(tree->get_local_mouse_position())) {
	tree_clicked = true;
	} else if (!mb->is_pressed()) {
	tree_clicked = false;
	}

But after executing replace_node(), tree_clicked is still true. That makes when triggered _handle_select, the pending_click_select always updated.

godot/editor/docks/scene_tree_dock.cpp

Lines 1871 to 1877 in 9f5309a

	void SceneTreeDock::_handle_select(Node *p_node) {
	if (tree_clicked) {
	pending_click_select = p_node;
	} else {
	_push_item(p_node);
	}
	}

Whenever we click mouse to trigger next input(), the pending_click_select will update to editor_selection with push_item. That makes the current selection changed and causes crash.

godot/editor/docks/scene_tree_dock.cpp

Lines 154 to 157 in 9f5309a

	if (!mb->is_pressed() && pending_click_select) {
	_push_item(pending_click_select);
	pending_click_select = nullptr;
	}