Skip to content

Conversation

@KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Sep 24, 2024

Fixes #97376
When doing scene operation, global redo is discarded.
When doing global operation, all scenes' redo is discarded.

@RobProductions
Copy link
Contributor

Thanks, this is great! I tested it by recreating @MajorMcDoom 's reproduction steps and it seems to work as expected :D

Capture2024-09-24.11-58-33.mov

@MajorMcDoom
Copy link
Contributor

Thanks, this is great! I tested it by recreating @MajorMcDoom 's reproduction steps and it seems to work as expected :D
Capture2024-09-24.11-58-33.mov

Likewise, can confirm, this is great!

Copy link
Member

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can all agree this makes sense.

@Jordyfel
Copy link
Contributor

Should discard_redo() be exposed? Seems reasonable that a user might want to do a similar thing in their undo/redo system

@Mickeon
Copy link
Member

Mickeon commented Sep 25, 2024

I'd say one thing at the time, worth discussing separately.

@akien-mga akien-mga added the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Sep 25, 2024
@akien-mga akien-mga merged commit 0a9d8f0 into godotengine:master Sep 25, 2024
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the it's_redover branch September 25, 2024 11:28
@akien-mga akien-mga changed the title Discard additional redo on commiting actions Discard additional redo on committing actions Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release enhancement topic:editor usability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Undo/Redo symmetry easily breaks when making edits from inspector

6 participants