Skip to content

Cache results for TranslationServer.compare_locales() #98236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Repiteo merged 1 commit into from
Oct 21, 2024
Merged

Cache results for TranslationServer.compare_locales() #98236

Repiteo merged 1 commit into from
Oct 21, 2024

Conversation

@timothyqiu
Copy link
Member

@timothyqiu timothyqiu commented Oct 16, 2024

4.x version of #98234

@timothyqiu timothyqiu added enhancement topic:core performance cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Oct 16, 2024
@timothyqiu timothyqiu added this to the 4.4 milestone Oct 16, 2024
@timothyqiu timothyqiu requested a review from a team as a code owner October 16, 2024 12:56
@Repiteo Repiteo merged commit b6547b0 into godotengine:master Oct 21, 2024
@Repiteo
Copy link
Contributor

Repiteo commented Oct 21, 2024

Thanks!

@timothyqiu timothyqiu deleted the locale-compare-cache-4.x branch October 21, 2024 23:47
@Spartan322 Spartan322 mentioned this pull request Jan 18, 2025
Merged
@timothyqiu timothyqiu mentioned this pull request Jul 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bruvzg bruvzg bruvzg approved these changes

Assignees

No one assigned

Labels

cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release enhancement performance topic:i18n

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@timothyqiu @Repiteo @bruvzg @akien-mga