Delete unused files of thirdparty libs (zlib, mbedtls) #98920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
changed the title
Member
|
Please update the readme with the deletion indtructions |
dustdfg
force-pushed
the
thirdparty_delete_unused
branch
from
b7424fc to
16e2374
Compare
akien-mga
reviewed
Nov 7, 2024
Signed-off-by: Yevhen Babiichuk (DustDFG) <[email protected]>
dustdfg
force-pushed
the
thirdparty_delete_unused
branch
from
16e2374 to
b607997
Compare
akien-mga
approved these changes
Nov 7, 2024
fire
approved these changes
Nov 7, 2024
Member
fire
left a comment
fire
left a comment
There was a problem hiding this comment.
The GitHub actions integration test still functions, the files are deleted, and the readme instructions are updated. It looks good to me.
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They weren't listed inside appropriate source lists (inside
SCsubfiles) so this change shouldn't affect compiled binaries at all but obviously check it