Raise the number of file handles on Windows #98921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomShaper
added
enhancement
platform:windows
cherrypick:4.3
fire
approved these changes
Nov 7, 2024
Member
fire
left a comment
fire
left a comment
There was a problem hiding this comment.
Raising the limit is a win, assuming the change doesn't break anything.
AThousandShips
changed the title
akien-mga
approved these changes
Nov 29, 2024
bruvzg
approved these changes
Nov 29, 2024
Member
bruvzg
left a comment
bruvzg
left a comment
There was a problem hiding this comment.
I think both MSVC and MinGW support this.
MinGW implementation seems to be dummy, so relevant only for MSVC. But should not break anything.
https://github.com/mingw-w64/mingw-w64/blob/master/mingw-w64-crt/stdio/_setmaxstdio.c
A better fix woul be to rewrite FileAccessWindows so it uses the Win32 API directly. However, this already brings value.
This is likely a better option.
Member
|
Thanks! |
TML233
added a commit
to TML233/godot
that referenced
this pull request
Dec 16, 2024
AThousandShips
removed
the
cherrypick:4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This raises the number to the maximum value according to the docs, which is 8192. The default is 512.
This should avoid many file access errors that happen in big projects during heavy operations dealing with many resources.
A better fix woul be to rewrite
FileAccessWindowsso it uses the Win32 API directly. However, this already brings value.I think both MSVC and MinGW support this. MSVC does for sure. Let's see what CI thinks about MinGW.