Fix setting TileMap data compatibility format broken by #98898. #99259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayjohn
approved these changes
Nov 15, 2024
Member
clayjohn
left a comment
clayjohn
left a comment
There was a problem hiding this comment.
I just spent the last hour bisecting this exact issue haha. This code is exactly what @akien-mga suggested in #98898 (comment), and it matches what the logic was before #98898 so it seems good.
I am also checking locally just in case
Member
|
Tested locally, and I can confirm this fixes the regression. |
Contributor
|
OH! I must've been using Akien's 3.x branch changelog as a reference for this, because the code exactly matches that implementation: |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not too sure why this check was rewritten differently than the source pre-#98898 but I can't load any old maps unless I restore it.