Skip to content

Buildsystem: Include icu4c into ft_linked_deps check #99883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
j20001970 wants to merge 1 commit into from
Closed

Buildsystem: Include icu4c into ft_linked_deps check #99883

j20001970 wants to merge 1 commit into from

Conversation

@j20001970
Copy link
Contributor

@j20001970 j20001970 commented Nov 30, 2024

Closes #91401

Building freetype, libpng, zlib, graphite, harfbuzz as system-provided while leaving icu4c as built-in leads to editor crash when loading GDExtension libraries that uses std::call_once in static initialization. By including builtin_icu4c into ft_linked_deps check, these libraries as a whole, will be either built-in or system-provided.

@j20001970 j20001970 requested a review from a team as a code owner November 30, 2024 19:02
@akien-mga akien-mga changed the title Buildsystem: include icu4c into ft_linked_deps check Buildsystem: Include icu4c into ft_linked_deps check Nov 30, 2024
@j20001970 j20001970 mentioned this pull request Dec 1, 2024
Closed
@Chaosus Chaosus added this to the 4.4 milestone Dec 1, 2024
@akien-mga akien-mga mentioned this pull request Dec 5, 2024
Merged
@j20001970
Copy link
Contributor Author

j20001970 commented Dec 12, 2024

There is a known bug (#100301) that breaks writing to stdout from GDExtension, it will affect Godot builds that use icu4c as system-provided if this get merged.

Closing this in favor of #100052

@j20001970 j20001970 closed this Dec 12, 2024
@j20001970 j20001970 deleted the builtin_icu branch December 12, 2024 08:14
@AThousandShips AThousandShips removed this from the 4.4 milestone Dec 12, 2024
@akien-mga akien-mga mentioned this pull request Jan 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

archived bug topic:buildsystem

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GDExtension libraries that use std::call_once during static initialization crash Godot editor with harfbuzz or icu4c as system-provided

3 participants

@j20001970 @Chaosus @AThousandShips