feat: Allow adding root certificate authorities#3
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3 +/- ##
==========================================
+ Coverage 60.47% 68.85% +8.37%
==========================================
Files 7 7
Lines 334 350 +16
==========================================
+ Hits 202 241 +39
+ Misses 128 97 -31
- Partials 4 12 +8 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@steven-zou @heww Let's fix and merge #4 first. And then I'll rebase and merge so you can review. |
steven-zou
requested changes
Oct 25, 2019
Collaborator
steven-zou
left a comment
steven-zou
left a comment
There was a problem hiding this comment.
Some minor comments left.
heww
reviewed
Oct 25, 2019
Harbor and Clair can be deployed with certificates signed by certificate authorities which are not present in the adapters host's root CA set. If that's the case, the corresponding clients will fail with well known error: `certificate signed by unknown authority`. Also it happens because the clients will not trust self-signed certificates, because they don’t recognise the signer as a trusted Root CA. In order to support custom CAs and self-signed certificates this commit adds support for `SCANNER_TLS_CLIENTCAS` and `SCANNER_TLS_INSECURE_SKIP_VERIFY` config envs. Resolves: #2 Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
heww
approved these changes
Oct 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.