Support serializing SymCrypt hash objects #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdams
approved these changes
May 23, 2025
dagood
approved these changes
May 23, 2025
Collaborator
dagood
left a comment
dagood
left a comment
There was a problem hiding this comment.
LGTM, just doc/style nits. I like the factoring, was fairly straightforward to follow along.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSSL does not currently support resumable hashing, where an in-progress hash operation's state is saved, and can be loaded later to finish the hash.
We do support serializing the hash state of the built-in OpenSSL providers, given that we can get a pointer to it and also we know it's memory layout. That doesn't work for other providers, though.
The SymCrypt provider is adding some custom parameters that allows getting and setting the internal hash object state. See microsoft/SymCrypt-OpenSSL#117.
This PR uses those new parameters to implement the hash serialization methods when using the SymCrypt provider.
For microsoft/go#1671.