feat: replace mulit statement parsing with comment aware parsing #691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* updates module name for outreach fork, only go related files for now.
dhui
requested changes
Jan 25, 2022
Member
dhui
left a comment
dhui
left a comment
There was a problem hiding this comment.
Did you hit issues with ; inside comments (or commented out statements)?
multistmt is intentionally naive for simplicity.
Maybe it's better to make multistmt configurable with different parsers. Then you could use DB specific parsers...
Also, any new code should have adequate test coverage.
| package main | ||
|
|
||
| import "github.com/golang-migrate/migrate/v4/internal/cli" | ||
| import "github.com/getoutreach/migrate/v4/internal/cli" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
existing multi-statement parsing was not aware of lines that start with
--this new function implementation could be extended in the future to support end of line comments as well as embedded comments.for now I chose to go with a very naive scanner/lexer, it could easily be converted to use a state machine to emit statements, but this method is simple enough to be placed directly in migrate with little changes. Possibly good enough for now.